Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.11] wait for provisioning state in AKS e2e tests #4271

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[release-1.11] wait for provisioning state in AKS e2e tests #4271

merged 1 commit into from
Nov 15, 2023

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind flake

What this PR does / why we need it:

Manual cherry-pick of #4255.

Which issue(s) this PR fixes:

Refs #3955

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 14, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de721bb) 56.70% compared to head (8db624e) 56.71%.
Report is 3 commits behind head on release-1.11.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.11    #4271      +/-   ##
================================================
+ Coverage         56.70%   56.71%   +0.01%     
================================================
  Files               187      187              
  Lines             19222    19222              
================================================
+ Hits              10899    10901       +2     
+ Misses             7693     7691       -2     
  Partials            630      630

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor Author

mboersma commented Nov 14, 2023 •
edited
Loading

[FAILED] failed to run clusterctl init

Some kind of general failure in most of the e2e tests in multiple PRs...

@mboersma
Copy link
Contributor Author

/retest

CecileRobertMichon
CecileRobertMichon reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@CecileRobertMichon
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e348ea689c20faf8f6c97ca65b8d25f231a71668

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit eec800c into kubernetes-sigs:release-1.11 Nov 15, 2023
19 checks passed
@mboersma mboersma deleted the cherry-pick-4255-to-release-1.11 branch November 15, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@nojnhuh nojnhuh Awaiting requested review from nojnhuh

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mboersma @CecileRobertMichon @k8s-ci-robot